89
u/new_check 12h ago
It's not dead. As long as you care about the craft and practice it, it will live regardless of what anyone else is doing.
17
u/Zapismeta 10h ago
And ai can work too just need to steer it well into the exact direction you want it and stay away from auto mode if you dont want a mangaled codebase
3
23
u/reallokiscarlet 11h ago
Rejected, contributor contacted, AI policy explained to contributor, all of a sudden they make a fork and test the changes there and start handwriting it when it doesn't work
20
u/JackNotOLantern 10h ago
Request changes: split into smaller PRs, below 10k lines each
12
u/Noname_1111 7h ago
below 1k lines if anything
I'm not reviewing anything that has more than 5 digits unless its a full refactor
6
u/JackNotOLantern 7h ago
10k is doable for me. But more is no sense. The only exception would be adding non-code text files, like md or test input files.
9
u/chadlavi 9h ago
What's to fear? Request changes. Ask the "author" to explain it. Don't merge it.
7
4
3
2
2
u/returnFutureVoid 9h ago
I chose to believe the last character in the additions is a b for billion.
2
2
u/_DrDigital_ 2h ago
The old code should not have been removed.
There should have been a guard added making sure the old code is never executed.
For that is the the way of the slop.
1
98
u/drex_vke 12h ago
generally it's a slop code this kind of commit.