MAIN FEEDS
Do you want to continue?
https://www.reddit.com/r/ProgrammerHumor/comments/1w49gx3/softwareengineeringisdead/p77gxfr/?context=3
r/ProgrammerHumor • u/redditor_286 • 23h ago
37 comments sorted by
View all comments
28
Request changes: split into smaller PRs, below 10k lines each
18 u/Noname_1111 18h ago below 1k lines if anything I'm not reviewing anything that has more than 5 digits unless its a full refactor 7 u/JackNotOLantern 17h ago edited 2h ago 10k is doable for me. But more is nonsense. The only exception would be adding non-code text files, like md or test input files. 1 u/tiajuanat 44m ago Even a full refactor. I've done a lot of major refactors myself and overseen even larger ones. In retrospect they've never needed to be done all at once, and were only done all at once because of someone's ego (admittedly sometimes mine)
18
below 1k lines if anything
I'm not reviewing anything that has more than 5 digits unless its a full refactor
7 u/JackNotOLantern 17h ago edited 2h ago 10k is doable for me. But more is nonsense. The only exception would be adding non-code text files, like md or test input files. 1 u/tiajuanat 44m ago Even a full refactor. I've done a lot of major refactors myself and overseen even larger ones. In retrospect they've never needed to be done all at once, and were only done all at once because of someone's ego (admittedly sometimes mine)
7
10k is doable for me. But more is nonsense. The only exception would be adding non-code text files, like md or test input files.
1
Even a full refactor. I've done a lot of major refactors myself and overseen even larger ones.
In retrospect they've never needed to be done all at once, and were only done all at once because of someone's ego (admittedly sometimes mine)
28
u/JackNotOLantern 21h ago
Request changes: split into smaller PRs, below 10k lines each